Add unpack/pack 'j' and 'J' support#6497
Merged
headius merged 2 commits intojruby:masterfrom Dec 16, 2020
Merged
Conversation
Basically just 'q' and 'Q' since we always behave like a 64-bit system. This may need to be reexamined when running on other bit widths if the values produced by 'j' and 'J' are being used to generate native pointer values.
Two Array#pack 'p' specs needed new tags because 'j' works now and was used for comparison before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for 'j' and 'J' in pack and unpack.
Two specs related to 'p' needed new tags because the only passed due to the brokenness of 'j'.
This eliminates around 250 spec tags.