Skip to content

[windows] fix gid#6460

Merged
headius merged 1 commit intojruby:masterfrom
ahorek:gid_fix
Nov 11, 2020
Merged

[windows] fix gid#6460
headius merged 1 commit intojruby:masterfrom
ahorek:gid_fix

Conversation

@ahorek
Copy link
Contributor

@ahorek ahorek commented Nov 10, 2020 •
edited
Loading

@ahorek ahorek changed the title WIP: [windows] fix gid [windows] fix gid Nov 10, 2020
@eregon
Copy link
Member

eregon commented Nov 10, 2020

Thanks for the PR.
Looks good to me, assuming there is no sensible way to get those on Windows.
MRI seems to do the same: https://github.com/eregon/actions-shell/runs/1381456341?check_suite_focus=true#step:4:649

Could you merge? :)

@headius headius merged commit 7d016c7 into jruby:master Nov 11, 2020
@headius headius added this to the JRuby 9.3.0.0 milestone Nov 11, 2020
@headius headius linked an issue Nov 11, 2020 that may be closed by this pull request
bundle install on Windows fails with NotImplementedError: stat.st_gid unsupported or native support failed to load #6458
Closed
@headius
Copy link
Member

headius commented Nov 11, 2020

@ahorek Thanks fo the fix!

@ahorek ahorek mentioned this pull request Dec 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@headius headius headius approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

JRuby 9.3.0.0

Development

Successfully merging this pull request may close these issues.

bundle install on Windows fails with NotImplementedError: stat.st_gid unsupported or native support failed to load

3 participants

@ahorek @eregon @headius