Do not optimize case with null value to switch#6443
Merged
headius merged 2 commits intojruby:jruby-9.2from Oct 21, 2020
Merged
Conversation
Optimized Fixnum switch is only possible when we have a `case` value and the `when` values are all int-ranged literal numbers. The NPE in jruby#6440 was due to us also trying to optimize homogeneous int case/when even if the case value was null (omitted in source). This patch limits the optimized switch generation to situations where we have a non-null `case` value. Fixes jruby#6440.
See jruby#6440 for an example of this situation breaking homogeneous case optimizations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimized Fixnum switch is only possible when we have a
casevalue and the
whenvalues are all int-ranged literal numbers.The NPE in #6440 was due to us also trying to optimize homogeneous
int case/when even if the case value was null (omitted in source).
This patch limits the optimized switch generation to situations
where we have a non-null
casevalue.Fixes #6440.