Fixes #6428: Date._strptime raises Java exception on invalid argument#6429
Merged
kares merged 1 commit intojruby:masterfrom Oct 7, 2020
Merged
Fixes #6428: Date._strptime raises Java exception on invalid argument#6429kares merged 1 commit intojruby:masterfrom
kares merged 1 commit intojruby:masterfrom
Conversation
kares
requested changes
Oct 7, 2020
test/mri/test_time.rb
Outdated
| assert_raise(ArgumentError) { Time.strptime('+09:00', '%z') } # [ruby-core:62351] by matz. | ||
| end | ||
|
|
||
| def test_strptime_type_error |
Member
There was a problem hiding this comment.
it's a bit confusing but the MRI suite is owner and imported from Ruby itself.
thus these could get lost easily on the next import, preferably use Ruby Specs under spec/ruby (maybe there is one - it's just tagged to be skipped) or simply move this to test/jruby/test_time.rb
Contributor
Author
There was a problem hiding this comment.
Sure, will do. Thanks
Contributor
Author
There was a problem hiding this comment.
Done, moved to test/jruby/test_time.rb
MariuszCwikla
force-pushed
the
strptime_exception
branch
from
d16392f to
0b26210
Compare
kares
pushed a commit
to kares/jruby
that referenced
this pull request
Oct 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6428