Clean up compile warnings and deprecations on Java 14#6402
Merged
headius merged 10 commits intojruby:masterfrom Sep 20, 2020
Merged
Clean up compile warnings and deprecations on Java 14#6402headius merged 10 commits intojruby:masterfrom
headius merged 10 commits intojruby:masterfrom
Conversation
This reverts commit 09721d6.
Deprecated in 9, replacement is to get no-arg constructor and call that instead. Some additional exception-handling required (lack of which was the reason newInstance is now deprecated).
The commit that deprecated this method, f64a3e0, also added code that uses it. Since there's no obvious replacement and the method itself just walks the trace and produces MRI formatted strings, I am undeprecating it.
Switch to using RoundingMode ordinals.
Probably in prep for value types...
newInstance was deprecated because it did not wrap exceptions raised during instantiation, so we emulate that behavior here by unwrapping.
backport9 library will now implement these using isAccessible on Java 8 and module isOpen on Java 9.
Member
Author
|
The remaining deprecations include the following:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of deprecation cleanup and a few more notable changes:
values()[ordinal]instead of the legacyvalueOf(int)MulticastSocket.joinGroup(InetAddress)is replaced with a call tojoinGroup(SocketAddress, NetworkInterface)that should be equivalent.yielda reserved identifer, so bare calls toyieldmethods must be qualified.