Skip to content

jrubyc: make valid java code when using annotations in java_signature#6390

Merged
headius merged 1 commit intojruby:masterfrom
byteit101:jrubyc_annotation
Sep 14, 2020
Merged

jrubyc: make valid java code when using annotations in java_signature#6390
headius merged 1 commit intojruby:masterfrom
byteit101:jrubyc_annotation

Conversation

@byteit101
Copy link
Member

@byteit101 byteit101 commented Sep 11, 2020

Setup

 require 'java'
java_import 'javax.ws.rs.Path'
java_import 'javax.ws.rs.GET'
java_import 'javax.ws.rs.Produces'

java_package 'com.headius.demo.jersey'
class HelloWorld

  java_signature "@GET public java.lang.String cliched_message2()"
  def cliched_message2
    "Hello World"
  end
end

Expected jrubyc --java output

...
@GET public java.lang.String cliched_message2() {
...

Actual jrubyc --java output prior to this PR

...
@GETpublic java.lang.String cliched_message2() {
...

Note no space

This PR fixes the space and formats all annotations alike

@headius
Copy link
Member

headius commented Sep 14, 2020

Failure is same issue as #6391. I will review.

@headius headius added this to the JRuby 9.3.0.0 milestone Sep 14, 2020
@headius headius merged commit cf0d462 into jruby:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@headius headius headius approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

JRuby 9.3.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@byteit101 @headius