Skip to content

Fix failing TestM17N#test_setbyte_range#6387

Merged
enebo merged 2 commits intojruby:masterfrom
k77ch7:ruby-2.6-fix-failing-test_setbyte_range
Sep 8, 2020
Merged

Fix failing TestM17N#test_setbyte_range#6387
enebo merged 2 commits intojruby:masterfrom
k77ch7:ruby-2.6-fix-failing-test_setbyte_range

Conversation

@k77ch7
Copy link
Contributor

@k77ch7 k77ch7 commented Sep 8, 2020

This fixes failing TestM17N#test_setbyte_range .

And sample.rb produces the same output.

sample.rb from TestM17N#test_setbyte_range

s = "\xE3\x81\x82\xE3\x81\x84".dup.force_encoding("UTF-8")
s.setbyte(0, 0x4f7574206f6620636861722072616e6765)
p s

MRI 2.6.6

% ruby -v sample.rb
ruby 2.6.6p146 (2020-03-31 revision 67876) [x86_64-darwin19]
"e\x81\x82い"

This PR

% ruby -v sample.rb
jruby 9.3.0.0-SNAPSHOT (2.6.5) 2020-09-03 ffffffffff OpenJDK 64-Bit Server VM 11.0.2+9 on 11.0.2+9 +jit [darwin-x86_64]
"e\x81\x82い"

@enebo enebo added this to the JRuby 9.3.0.0 milestone Sep 8, 2020
@enebo enebo merged commit 6722d78 into jruby:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

JRuby 9.3.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@k77ch7 @enebo