Skip to content

Fixes for non-native execution#6383

Merged
headius merged 8 commits intojruby:masterfrom
headius:macos_aarch64
Sep 19, 2020
Merged

Fixes for non-native execution#6383
headius merged 8 commits intojruby:masterfrom
headius:macos_aarch64

Conversation

@headius
Copy link
Member

@headius headius commented Sep 2, 2020

Several key commands no longer work with native support disabled. We would like to allow as much of Ruby to run as possible when running in pure-Java mode.

These are fixes to better support the pure-Java runtime mode.

This prevented IRB from starting up when native support is not
available, since it attempts to reopen stdio streams using their
numeric file descriptors.
We still just return a very high value when getrlimit is not
available, but at least it is the right type now. This allows
`bundle install` to succeed without native support.
@headius headius added this to the JRuby 9.3.0.0 milestone Sep 2, 2020
@headius headius marked this pull request as ready for review September 19, 2020 20:35
@headius
Copy link
Member Author

headius commented Sep 19, 2020

With the fixes here I am able to install gems including Rails, generate a Rails app, bundle install that app, boot the server and handle requests. There will be other fixes to be made but this is a good point to merge.

@headius headius merged commit 39d258d into jruby:master Sep 19, 2020
@headius headius deleted the macos_aarch64 branch September 19, 2020 21:07
@headius
Copy link
Member Author

headius commented Dec 13, 2020

@enebo We should consider backporting these to the 9.2 line if we expect to do a 9.2.15.0 or higher, since they are small and may prevent issues like ruby/rubygems#4129 from affecting future 9.2 maintenance updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant