Fallback primitive numeric ops to object dispatch#6370
Merged
headius merged 1 commit intojruby:masterfrom Sep 1, 2020
Merged
Conversation
Numeric operators with a literal long-ranged integer or double- ranged float on the RHS attempt to dispatch directly without an object, to avoid type-checking an incoming boxed Fixnum or Float object. However when the primitive type does not match the type of the LHS, we fell back to slow-path uncached invocation at indy call sites. This patch instead falls back on "normal" invocation, currying the boxed number as the sole argument to a second call site's invoker. This allows these primitive numeric ops to fall back to fully optimizable object-based dispatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numeric operators with a literal long-ranged integer or double-ranged float on the RHS attempt to dispatch directly without an object, to avoid type-checking an incoming boxed Fixnum or Float object. However when the primitive type does not match the type of the LHS, we fell back to slow-path uncached invocation at indy call sites.
This patch instead falls back on "normal" invocation, currying the boxed number as the sole argument to a second call site's invoker. This allows these primitive numeric ops to fall back to fully optimizable object-based dispatch.