[fix][backport] Ensure copy_stream write sends all bytes read#6348
Merged
kares merged 1 commit intojruby:jruby-9.2from Jul 30, 2020
Merged
[fix][backport] Ensure copy_stream write sends all bytes read#6348kares merged 1 commit intojruby:jruby-9.2from
kares merged 1 commit intojruby:jruby-9.2from
Conversation
On target streams that may do partial reads, the logic here fails to write all content read from the source stream. The return value of Channel.write is never checked, but the total bytes written is incremented, resulting in silently losing data. The patch loops until all bytes have been written to the output channel after each read. CRuby does similar logic. We may need to add additional blocking write or thread event checks here, in case the target stream blocks during the write loop, but that will require the different `transfer` paths to be expanded to support nonblocking IO channels. Fixes jruby#6078
Member
Author
|
was thinking this one is rather small and low risk ... maybe it doesn't have to wait till 9.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On target streams that may do partial reads, the logic here fails
to write all content read from the source stream. The return value
of Channel.write is never checked, but the total bytes written is
incremented, resulting in silently losing data.
The patch loops until all bytes have been written to the output
channel after each read.
CRuby does similar logic. We may need to add additional blocking
write or thread event checks here, in case the target stream
blocks during the write loop, but that will require the different
transferpaths to be expanded to support nonblocking IOchannels.
Fixes #6078