Reconfigure some CI builds and add JDK14#6301
Merged
headius merged 6 commits intojruby:masterfrom Jun 28, 2020
Merged
Conversation
By using threshold=1 with no background jit, this should cause any code called twice to hit both startup and full interpreter modes. Given that we test both interpreters in many places and have a good corpus of compiler/interpreter specs, I believe we can drop some of the "fullint" runs.
* Remove "fullint" runs in favor of new "int" flags that encourage a full build. * Add invokedynamic to some of the JDK11 builds. * Duplicate some of the JDK11 builds for JDK14.
We will begin transitioning toward using AppCDS rather than the -Xverify:none flag in the future, but for now this will eliminate the warning on Java 13 and above.
Member
Author
|
Two things failed on JDK14:
|
As of JDK13, BindException is now used to represent EACCES in addition to EADDRINUSE and EADDRNOTAVAIL, so we need to use the message to differentiate. See the following OpenJDK change, which altered the exception type raised for EACCES: https://bugs.openjdk.java.net/browse/JDK-8220738 This led to a failure in jruby/test_socket.rb:test_udp_socket_bind due to our assumption that BindException was only used for the two EADDR* errors.
The message for EPFNOSUPPORT was used for EADDRNOTAVAIL, so I have fixed both.
Member
Author
|
The two minor patches here (handle BindException based on message and properly assign errno for a couple others) have been cherry-picked to 9.2.12, to improve compatibility with Java 13+. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a few changes to our Travis CI runs: