Some fixes, tweaks, and new tools for working with IR#6279
Merged
enebo merged 4 commits intojruby:masterfrom Jun 15, 2020
Merged
Some fixes, tweaks, and new tools for working with IR#6279enebo merged 4 commits intojruby:masterfrom
enebo merged 4 commits intojruby:masterfrom
Conversation
When running -X-C, only print for -Xir.print once, when the threshold is met, not every time the method is called until the threshold
Don't print instructions if there aren't any and we're using BBs instead
Member
|
d47b5da is weird but not from your change. getInstructions should never return null so the first half of that if should not exist (unless there is concurrent access and then we should ask why that is happening). The other thing which bothers me is that checking for no instructions seems like a weird mechanism for signalling it is already a full build. We should at least probably check the ic itself instead of what instrs it happens to have. None of that involves you PR though :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possibly best reviewed by looking at the individual commits.