Skip to content

[etc] implement #confstr and #pathconf#6266

Merged
headius merged 5 commits intojruby:masterfrom
ahorek:confstr_and_pathconf
Oct 6, 2020
Merged

[etc] implement #confstr and #pathconf#6266
headius merged 5 commits intojruby:masterfrom
ahorek:confstr_and_pathconf

Conversation

@ahorek
Copy link
Contributor

@ahorek ahorek commented Jun 4, 2020

depends on jnr/jnr-posix#154

@ahorek ahorek force-pushed the confstr_and_pathconf branch 3 times, most recently from 925b26a to 457910d Compare June 9, 2020 12:37
@headius
Copy link
Member

headius commented Sep 21, 2020

@ahorek We should either get an impl in place or close this, I think...

@ahorek ahorek closed this Sep 23, 2020
@ahorek ahorek changed the title [etc] add definitions for #confstr #pathconf WIP: [etc] implement #confstr and #pathconf Sep 24, 2020
@ahorek ahorek reopened this Sep 24, 2020
@ahorek ahorek force-pushed the confstr_and_pathconf branch 2 times, most recently from 297ad03 to 6c820e3 Compare September 24, 2020 16:13
@ahorek
Copy link
Contributor Author

ahorek commented Sep 24, 2020

@headius let's implement it!

could you review jnr/jnr-posix#154 ? Thanks

@headius
Copy link
Member

headius commented Sep 29, 2020

@ahorek I reviewed and merged jnr/jnr-posix#154 and can do a release any time. For now I've deployed a snapshot build of 3.1.1 which can be used to test this PR (we should release and use 3.1.1 non-snapshot before merging).

@headius
Copy link
Member

headius commented Sep 29, 2020

Use 3.1.1-SNAPSHOT as the version in JRuby to test.

@headius
Copy link
Member

headius commented Sep 29, 2020

Oops, my mistake... 3.1.1 already went out, so it's 3.1.2-SNAPSHOT.

@ahorek ahorek force-pushed the confstr_and_pathconf branch from 6c820e3 to f8eb7d2 Compare September 29, 2020 17:43
@ahorek ahorek changed the title WIP: [etc] implement #confstr and #pathconf [etc] implement #confstr and #pathconf Sep 29, 2020
@ahorek ahorek requested a review from headius September 29, 2020 18:13
@ahorek
Copy link
Contributor Author

ahorek commented Sep 29, 2020

ok, there's one small fix on Windows jnr/jnr-posix#155

this should be ready for review. Thanks @headius

@headius
Copy link
Member

headius commented Sep 29, 2020

I merged jnr/jnr-posix#155 and pushed a new snapshot. Will give it a few minutes and then restart CI to pick up the change.

@headius
Copy link
Member

headius commented Oct 5, 2020

Looks good to me, I will push a jnr-posix release and we can update and merge.

headius added a commit that referenced this pull request Oct 5, 2020
@headius
Copy link
Member

headius commented Oct 5, 2020

I released jnr-posix and went ahead and updated master to use it. You can update the PR to the released version and once this goes green we'll merge it!

@headius
Copy link
Member

headius commented Oct 5, 2020

I forgot I can make the change too. 🤪

@headius headius added this to the JRuby 9.3.0.0 milestone Oct 6, 2020
@headius headius merged commit d0ecf53 into jruby:master Oct 6, 2020
@headius
Copy link
Member

headius commented Oct 6, 2020

All good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants