Skip to content

Fix jruby jars deploy#6262

Merged
headius merged 1 commit intojruby:masterfrom
headius:fix_jruby_jars
Jun 4, 2020
Merged

Fix jruby jars deploy#6262
headius merged 1 commit intojruby:masterfrom
headius:fix_jruby_jars

Conversation

@headius
Copy link
Member

@headius headius commented Jun 3, 2020

Wrestling with CI

9.2.11.1 appeared to cause some issues resulting in the following
error:

```
INFO] --- gem-maven-plugin:1.0.7:initialize (default-initialize) @ jruby-jars ---
Downloading from mavengems: mavengem:https://rubygems.org/org/jruby/jruby-complete/9.2.11.1/jruby-complete-9.2.11.1.jar
LoadError: no such file to load -- rubygems/defaults/jruby
  require at org/jruby/RubyKernel.java:1071
   (root) at <script>:1
```

I believe the change here fixes this problem, since there's no
need to explicitly require the JRuby defaults file for RubyGems.

The jruby-jars change uses a 9.3 snapshot to pick up this change.
We will want to change it to 9.3.0.0 non-snapshot when it is
released.
@headius headius added this to the Non-Release milestone Jun 4, 2020
@headius
Copy link
Member Author

headius commented Jun 4, 2020

Not sure if this will run into problems, but 9.2.11.1 was having problems as seen here:

https://travis-ci.org/github/jruby/jruby/jobs/694452697

We should change this to the non-snapshot 9.3 version when it is released. I will file a separate issue for that.

@headius headius merged commit 888673f into jruby:master Jun 4, 2020
@headius headius deleted the fix_jruby_jars branch June 4, 2020 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant