Raise proper error for missing URLResource target#6256
Merged
headius merged 2 commits intojruby:masterfrom Jun 3, 2020
Merged
Conversation
This isn't great since we're allowing a null field and checking for null, but the logic surrounding this has been designed to lazily create the channel or stream in question. This is likely due to the use of URLResource and its siblings as generic path/URI mungers that can clean up and canonicalize/abosolutize even paths that do not exist. Rather than attempt to isolate that behavior (which might be a lot more work), I've opted to mimic FileResource in raising an error along the lazy path when it's clear we don't have a resource in hand to open. This fixes jruby#6219.
Member
Author
|
Retargeted to 9.2.12 and cherry-picked into #6285. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6219.