Don't double-slash path elements when canonicalizing#6239
Merged
headius merged 6 commits intojruby:masterfrom May 23, 2020
Merged
Don't double-slash path elements when canonicalizing#6239headius merged 6 commits intojruby:masterfrom
headius merged 6 commits intojruby:masterfrom
Conversation
Not sure why this is here, but there's no case where a classloader URI should have anything like a UNC double-slashed path.
Member
Author
|
This fix seems right, but there's a number of our own tests that expect the double slash in a classloader URI. I believe these are in error and we should always normalize to single slashes when canonicalizing a classloader URI path. |
Member
Author
|
See also #3150 that added at least one of these tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6045