Closed
Conversation
Basically just treats simple 7-bit regexps as string or character splitting.
Member
Author
|
The logic I ported over here is fine, but then it drops into older logic that turns a freshly-unwrapped string delimeter back into a regexp and doesn't really save us a great deal. The performance issue for which I explored this (#5857) has also been resolved by making other improvements. I'm going to ditch this, since it was a 2.7 change anyway and just doing a proper re-port of the split logic would be a better option. Low priority, will refile as a 9.4 item. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same optimization that CRuby 2.7 did for simple regexp in String#split.
This has a tremendous impact on performance of patterns like
str.split(/,/)but the code isn't passing all specs yet. Pushing this PR now so we don't lose the code.