Merged
Conversation
This updates our fnmatch port to more closely resemble the code in CRuby. Specifically this work is intended to fix jruby#6193 but the additional cleanup may fix other issues. Remaining work mostly involves properly advancing the character pointers in the presence of a multibyte encoding.
This fixes the remaining failurue in CRuby's test_fnmatch. A bit of refactoring came along for the ride. Part of work for jruby#6193
CRuby will blow by this code because even s == send will just yield a null byte. We preemptively guard against p or s being at their respective ends already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will have a few commits to re-port the fnmatch logic from CRuby. Will fix #6193 and others.