Java classes with signatures should be reified#623
Merged
headius merged 4 commits intojruby:masterfrom May 21, 2013
Merged
Conversation
docs/README.test
Outdated
Member
There was a problem hiding this comment.
This is incorrect. bin/rspec will be generated when rspec gem is installed by install-dev-gems ant target.
Member
|
Hello. I updated the summary to reflect the intention of the pull request more accurately. |
ghost
assigned
Contributor
Author
|
Thanks BanzaiMan, fixed! |
Member
|
Looks good, merging! |
headius
added a commit
that referenced
this pull request
May 21, 2013
Java classes with signatures should be reified
Member
|
FYI, I updated the readme to a more direct ant target for compiling tests: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible that this actually isn't broken and I'm using the API improperly. I had to put the following change into a patch to use a java_signature that took a parameter.
Let me know!