Default to space padding for "special" formats#6228
Merged
headius merged 1 commit intojruby:masterfrom May 22, 2020
Merged
Conversation
Member
|
@headius yeah maybe that works and is only a single pass over the format string. I guess it seems reasonable if that is really a hard and fast rule. |
Member
Author
|
We will go with this fix for now but may want to rework this and add a format cache in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #6169 and I believe matches CRuby for the "special" formats handled here, but I am unsure if this is the right way to fix it. CRuby has something similar in its complicated strftime code, but they do not have a separate parser for date formats like we do.
@enebo I feel like this is something that should be done in the strftime parser; it should see that the next token is going to want space padding and insert the FORMAT_OUTPUT token with appropriate flags. What do you think?