Merged
Conversation
This was still being used by Nokogiri as recently as Feb 2019, so we can't delete it for some time. This usage was removed in the middle of the 9.2 series by @jvshahid in sparklemotion/nokogiri#1874. See sparklemotion/nokogiri#2027 for recent work to remove deprecated calls from Nokogiri.
Member
Author
|
I have removed what I thought was safe to remove. There are some remaining items:
|
kares
reviewed
Apr 27, 2020
Member
kares
left a comment
kares
left a comment
There was a problem hiding this comment.
👍 do not recall any of these being used around JRuby exts such AR-JDBC/JRack/JOSSL
... FileExistsExceptionwas used in older jossl at some point, but that is handled by now.
for the removed channel classes I found one usage in multi_git gem with a note "This is a Hack" 😉
enebo
approved these changes
Apr 27, 2020
Member
enebo
left a comment
enebo
left a comment
There was a problem hiding this comment.
Always got to cut the cord at some point. None of these were likely to be used externally either.
Confusion
added a commit
to Confusion/racc
that referenced
this pull request
Dec 27, 2020
RubyContinuation isn't used any more by the code, is deprecated and will be removed in the future (per jruby/jruby#6194).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any classes deprecated and unused for more than two years will be deleted in JRuby 9.3. Most of these have been deprecated much longer.