[ji] java_import now raise NameError on invalid names#6182
Merged
kares merged 4 commits intojruby:masterfrom Apr 20, 2020
Merged
[ji] java_import now raise NameError on invalid names#6182kares merged 4 commits intojruby:masterfrom
kares merged 4 commits intojruby:masterfrom
Conversation
this is considered a fix since it will allow importing Java class-names using non-ascii capital characters ...
Member
|
Looks like some nice error messages to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
given invalid import names
java_importwill raiseNameError,removing
constant =~ /^[A-Z].*/capitalization validation, leaving that part toconst_setthe
[A-Z]validation did not handle multi-byte capital (UTF-8) characters that well ...in theory Java class names support the full Unicode set not just ascii characters.