Skip to content

Remove usages of deprecated ConfigMap (again)#6166

Merged
kares merged 1 commit intojruby:masterfrom
pirj:remove-usages-of-deprecated-config_map
Apr 4, 2020
Merged

Remove usages of deprecated ConfigMap (again)#6166
kares merged 1 commit intojruby:masterfrom
pirj:remove-usages-of-deprecated-config_map

Conversation

@pirj
Copy link
Contributor

@pirj pirj commented Apr 3, 2020

This issue was initially reported here: #6030

It breaks rspec-rails' jruby-head build: https://travis-ci.org/github/rspec/rspec-rails/jobs/670723126

This was supposed to fix it: https://github.com/jruby/jruby/pull/5966/files

And this as well: 637b17c#diff-2d9baebc59d1732672e3dba0ba309e84

Somehow, those changes did not reflect on master.

@pirj
Copy link
Contributor Author

pirj commented Apr 3, 2020

Errors don't seem to be related:

     [exec]   test_empty_backquotes:				.: (0.005730)
     [exec]   test_system_special_commands:				E
     [exec] ===============================================================================
     [exec] Error: test_system_special_commands(TestBackquote): Errno::ENOENT: No such file or directory - No such file or directory
     [exec] org/jruby/RubyProcess.java:916:in `waitpid'
     [exec] org/jruby/RubyKernel.java:1769:in `system'
     [exec] /home/travis/build/jruby/jruby/test/jruby/test_backquote.rb:33:in `test_system_special_commands'
     [exec]      30: 
     [exec]      31:   def test_system_special_commands
     [exec]      32:     if File.exists?("/bin/true")
     [exec]   => 33:       assert(system("/bin/true"))
     [exec]      34:       assert_equal(0, $?.exitstatus)
     [exec]      35:     end
     [exec]      36: 
     [exec] org/jruby/RubyKernel.java:1263:in `catch'
     [exec] org/jruby/RubyKernel.java:1258:in `catch'
     [exec] org/jruby/RubyKernel.java:1263:in `catch'
     [exec] org/jruby/RubyKernel.java:1258:in `catch'
A Fiber that has been abandoned

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received

pirj added a commit to rspec/rspec-rails that referenced this pull request Apr 3, 2020
There's a pull request pending to fix JRuby's deprecation messages,
however some specs there fail, and there's no certainty when it will be
merged.
jruby/jruby#6166
pirj added a commit to rspec/rspec-rails that referenced this pull request Apr 3, 2020
There's a pull request pending to fix JRuby's deprecation messages,
however some specs there fail, and there's no certainty when it will be
merged.
jruby/jruby#6166
@kares
Copy link
Member

kares commented Apr 4, 2020

Thanks Phil, this is looking good!

@kares kares added this to the JRuby 9.3.0.0 milestone Apr 4, 2020
@kares kares merged commit 0af1b09 into jruby:master Apr 4, 2020
@pirj pirj deleted the remove-usages-of-deprecated-config_map branch April 4, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants