Remove usages of deprecated ConfigMap (again)#6166
Merged
kares merged 1 commit intojruby:masterfrom Apr 4, 2020
Merged
Conversation
Related: jruby#6030 https://github.com/jruby/jruby/pull/5966/files jruby@637b17c#diff-2d9baebc59d1732672e3dba0ba309e84 Somehow, those changes do not reflect on `master`.
Contributor
Author
|
Errors don't seem to be related: |
pirj
added a commit
to rspec/rspec-rails
that referenced
this pull request
Apr 3, 2020
There's a pull request pending to fix JRuby's deprecation messages, however some specs there fail, and there's no certainty when it will be merged. jruby/jruby#6166
pirj
added a commit
to rspec/rspec-rails
that referenced
this pull request
Apr 3, 2020
There's a pull request pending to fix JRuby's deprecation messages, however some specs there fail, and there's no certainty when it will be merged. jruby/jruby#6166
Member
|
Thanks Phil, this is looking good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was initially reported here: #6030
It breaks
rspec-rails'jruby-headbuild: https://travis-ci.org/github/rspec/rspec-rails/jobs/670723126This was supposed to fix it: https://github.com/jruby/jruby/pull/5966/files
And this as well: 637b17c#diff-2d9baebc59d1732672e3dba0ba309e84
Somehow, those changes did not reflect on
master.