Restore $! when catching exception.#615
Merged
enebo merged 1 commit intojruby:masterfrom Apr 24, 2013
Merged
Conversation
Member
|
This works, but I am a bit worried about committing this. I have not looked at MRI source, but ideally we should add smarts to FileStat to avoid setting |
Contributor
Author
|
Yup. As I said, hack-ish. The alternative is to modify |
enebo
added a commit
that referenced
this pull request
Apr 24, 2013
Restore $! when catching exception. In most cases jnr-posix on an error will throw and not get caught like this. This is a special case and without significant changes jnr-posix this looks like the best fix to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hack-ish workaround for JRUBY-7134 that restores
$!when an exception is thrown when checking whether the dir exists.Added also pull request for rubyspec.