Subtract begin offset for partial substring in sprintf 's'#6138
Merged
headius merged 3 commits intojruby:jruby-9.2from Mar 25, 2020
Merged
Subtract begin offset for partial substring in sprintf 's'#6138headius merged 3 commits intojruby:jruby-9.2from
headius merged 3 commits intojruby:jruby-9.2from
Conversation
This gets a bit deep into how string buffers are used and shared but since it was exposed as a bug (jruby#6137) and CRuby does the same copy-on-write buffer treatment that JRuby does, it seemed an appropriate spec to add.
Member
Author
|
Moving forward with this since we want to put a release out tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6137 for the original bug report. This PR includes the change proposed there along with some new doco for
nthand a spec.