Conversation
See jruby#6127 for a case that needed to be able to add exit hooks from Java, to shut down the executor associated with the Timeout library.
Replaces Ruby-based internals tweaking from jruby#6127.
Member
|
👍 somehow the name confused me |
Member
Author
|
I went with that name mostly because we already had |
* Allow adding at_exit hooks while running at_exit hooks * Adopt new exit error code from exit-within-at_exit * Set exit code to 1 if errors during at_exit * Split up catch block to use real exception types rather than type checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to register an exit hook from Java using a simple function object. It also switches the Timeout library from using
at_exitto using this API for executor shutdown.See #6127 which, due to the lack of such an API, was forced to dig around in JRuby internals from Ruby code.
There may be other places where this could be used but I did not audit other
at_exitconsumers.