Do all socket connects nonblocking for interrupts#6128
Merged
headius merged 1 commit intojruby:masterfrom Apr 6, 2020
Merged
Conversation
Direct blocking connects can't be interrupted through normal Ruby thread events because a hard interrupt would destroy the related channel. Like other IO, this change uses fully non-blocking channels and selectors to handle blocking. Fixes jruby#6126
headius
force-pushed
the
interruptible_socket_connect
branch
from
5676637 to
23831b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct blocking connects can't be interrupted through normal Ruby
thread events because a hard interrupt would destroy the related
channel. Like other IO, this change uses fully non-blocking
channels and selectors to handle blocking.
Fixes #6126