RubyTime initialization refactor#6117
Merged
headius merged 8 commits intojruby:masterfrom Mar 12, 2020
Merged
Conversation
This carries the `instant` logic through the calculation of seconds and subsections to avoid constructing more DateTime objects than necessary. Validation of the base integer values is done during construction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initialization path for RubyTime had grown unwieldy, with many paths crossing through the same logic and obscuring each others behavior. This refactor does the following:
This passes CRuby and rubyspec Time tests and will be the baseline for adding support for the new duck-typed "Timezone" object in 2.6.