Skip to content

CGI.escapeHTML restore the original encoding#6097

Merged
enebo merged 1 commit intojruby:masterfrom
ahorek:cgi_fix
Mar 2, 2020
Merged

CGI.escapeHTML restore the original encoding#6097
enebo merged 1 commit intojruby:masterfrom
ahorek:cgi_fix

Conversation

@ahorek
Copy link
Contributor

@ahorek ahorek commented Feb 25, 2020

fixes #6093

@headius
Copy link
Member

headius commented Mar 2, 2020

@enebo Perhaps this is safe for 9.2.11?

@enebo enebo merged commit 7a05219 into jruby:master Mar 2, 2020
@enebo enebo added this to the JRuby 9.2.11.0 milestone Mar 2, 2020
@enebo
Copy link
Member

enebo commented Mar 2, 2020

Fixes something I know which happens in web apps (bogus encoded text being source from users). Landing this seems like a net loss in new user reports from this behavioral difference with MRI. Seems reasonably safe too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CGI.escapeHTML crashes on invalid byte sequence where CRuby does not

3 participants