Skip to content

throw ArgumentError instead of SecurityError#6064

Closed
ahorek wants to merge 1 commit intojruby:masterfrom
ahorek:error
Closed

throw ArgumentError instead of SecurityError#6064
ahorek wants to merge 1 commit intojruby:masterfrom
ahorek:error

Conversation

@ahorek
Copy link
Contributor

@ahorek ahorek commented Feb 15, 2020 •
edited
Loading

String tests Poison null byte raises error
Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { |failure, _opts| raise failure }

   expected ArgumentError, got #<SecurityError: string contains null byte> with backtrace:
     # ./spec/ffi/string_spec.rb:27:in `block in <main>'
     # ./spec/ffi/string_spec.rb:27:in `block in <main>'
     # ./spec/ffi/string_spec.rb:27:in `block in <main>'

#5948

@headius
Copy link
Member

headius commented Feb 16, 2020

Cherry-picked to update_ffi in bcec463.

@headius headius closed this Feb 16, 2020
@headius headius added this to the JRuby 9.3.0.0 milestone Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

JRuby 9.3.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ahorek @headius