Mark custom classloaders as parallel capable#6062
Merged
headius merged 2 commits intojruby:masterfrom Mar 4, 2020
Merged
Conversation
These classloaders apparently led to a deadlock inside Azul Zing when using the ReadyNow feature that saves class and JIT data betwen runs. This should be a benign change, since these loaders typically only ever load one class, but we'll let it back for a while.
There's additional state changes here but they all appear to be covered by synchronization.
headius
changed the title
Member
Author
|
I have also marked JRubyClassLoader as parallel capable, since all its internal state appears to be protected by synchronized sections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These classloaders apparently led to a deadlock inside Azul Zing
when using the ReadyNow feature that saves class and JIT data
betwen runs. This should be a benign change, since these loaders
typically only ever load one class, but we'll let it back for a
while.