[fix] restore rescue nil performance #6031
Conversation
|
I wish there were a better way to test this but everything I can think of in Ruby would defeat the optimization. Perhaps we could introduce something that tests the IR directly? Confirm that something like Looks good in any case, thank you! |
|
hey, thanks for the merge and response. had the idea of doing like a 'performance' unit test (haven't looked into it). |
|
That could work too. My main worry about performance tests is that Travis will sporadically be slow, or become slow, for a given build. It would be better than nothing though. We could also look at just setting up a periodic dedicated-server run of all benchmarks we've committed, tracking them over time like the Pypy project has done. Then at least we could get some mild notification if something regresses seriously. |
initially I thought
rescue nilback-trace capturing is disabled on purposebut seems it simply got lost at f64a3e0
follow-up on #6014
should introduce some perf.testing to avoid loosing performance