properly synchronize globalInlineCount#5943
Merged
kares merged 1 commit intojruby:masterfrom Oct 26, 2019
Merged
Conversation
Member
|
nice find, this piece is just quite weird (there's still |
Member
|
with PR as it is globalInlineCount should be made an int. The usage of this synchronize was so narrow I don't think in practice we would ever see the field change while it is synched. That said, either suggested fix is better (I would prefer AtomicInt myself). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
synchronization using a boxed primitive isn't reliable, because the field's value could be changed while a thread is in a synchronized block.