Restructure indy-based math binding.#5939
Merged
kares merged 1 commit intojruby:masterfrom Oct 24, 2019
Merged
Conversation
This primarily adds a hard RubyFixnum or RubyFloat type check on self, to ensure we're not even attempting fast bindings for other types. It also reduces overall binding overhead in that case by moving direct indy logic out of the fail path and moves a couple more adapted method handles to constants. Fixes jruby#5938.
enebo
approved these changes
Oct 23, 2019
Member
|
👍 this should resolve the issue. |
kares
added a commit
to kares/jruby
that referenced
this pull request
Oct 25, 2019
this seems to have gone unnoticed at jrubyGH-5939 also avoid warnings on == null condition being always true
kares
added a commit
that referenced
this pull request
Oct 25, 2019
this seems to have gone unnoticed at GH-5939 also avoid warnings on == null condition being always true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This primarily adds a hard RubyFixnum or RubyFloat type check on
self, to ensure we're not even attempting fast bindings for other
types. It also reduces overall binding overhead in that case by
moving direct indy logic out of the fail path and moves a couple
more adapted method handles to constants.
Fixes #5938.