Merged
Conversation
Member
|
very nice! jruby still slower than MRI - did you happen to find out where time is being spent? |
headius
added a commit
that referenced
this pull request
Oct 23, 2019
Additional optimization on top of #5928.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature String#unpack1 should be an optimization, but on jruby it's significantly slower even more than #unpack.first
examples from stdlib
jruby/lib/ruby/stdlib/base64.rb
Line 59 in 4e8bb26
jruby/lib/ruby/stdlib/erb.rb
Line 995 in d03c357