Use new RubyStringBuilder.str api to create inspected string for Exception#5927
Merged
kares merged 2 commits intojruby:masterfrom Oct 21, 2019
Merged
Conversation
kares
reviewed
Oct 21, 2019
| new StringBuilder(2 + rubyClass.length() + 2 + exception.size() + 1). | ||
| append("#<").append(rubyClass).append(": ").append(exception.getByteList()).append('>') | ||
| ); | ||
| String exceptionStartStr = new StringBuilder(2 + rubyClass.length() + 2).append("#<").append(rubyClass).append(": ").toString(); |
Member
There was a problem hiding this comment.
you should nuke the explicit StringBuilder here - it's not needed (you could just + if the API is not enough)
Contributor
Author
There was a problem hiding this comment.
I think nuking is done now.
Member
There was a problem hiding this comment.
the last round-trip (Ruby -> Java -> Ruby string) is redundant, but we can fix that later ...
Compiler makes it as good as it can be and code is easier to read.
Member
|
Super cool. I may change the signature to be ruby,string,irubyobject,string,irubyobject,string but thanks for this work. We really appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pull request fix for #5923