encoding parameter for Dir.open, Dir.new #3205 #4495#5915
encoding parameter for Dir.open, Dir.new #3205 #4495#5915headius merged 2 commits intojruby:masterfrom
Conversation
|
In f5b78ad I've added fix for |
|
looking good, still could we maybe have : |
|
@kares thanks for hints. Normally I would do like you suggested, but
Do you agree to do more refactoring (including setup/teardown and other existing tests not related to my change?) |
|
@MariuszCwikla oh I did not check, in that case all 👍 from me |
|
The modified |
|
I notice that one particular piece of logic seems to be lost: in Was that behavior in error? It appears to have been there since 1.9. I will commit a change to remove the [] bits, but we do need confirmation about that logic. |
Fixes #4495 and partial fix for #3205