Implement Java::JavaLang::Throwable#full_message#5908
Merged
headius merged 1 commit intojruby:masterfrom Oct 8, 2019
Merged
Conversation
Since Java throwables are treated similarly to regular Ruby exceptions, I think it makes sense to implement `full_message` for easier logging and debugging. This moves the `RubyException` implementation to `TraceType` so that it can be shared with `Throwable`. I had to change the `exception` argument type in `printBacktraceMRI` in order to support the exception-like object that `Throwable` provides. Closes: jruby#5906
Member
|
The original intent of actually propagating Java exceptions was indeed to make them duck type as Ruby exceptions, so this makes sense. |
Member
|
Looks good to me. The whitespace changes are a little annoying, but the whitespace that was there shouldn't have been. If you do any future PRs, try to keep the whitespace changes in a separate commit, so they don't show up in git blame as being related to the actual change. Thank you for the patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Java throwables are treated similarly to regular Ruby exceptions,
I think it makes sense to implement
full_messagefor easier loggingand debugging.
This moves the
RubyExceptionimplementation toTraceTypeso that itcan be shared with
Throwable. I had to change theexceptionargumenttype in
printBacktraceMRIin order to support the exception-likeobject that
Throwableprovides.Closes: #5906