Enable recursive fd redirection for popen logic.#5898
Merged
headius merged 1 commit intojruby:masterfrom Oct 27, 2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #5865
The logic here was disabled because it makes changes to file descriptors in the parent process, which could cause a race if multiple threads try to
popenusing the same descriptors. However the race only affects subprocess launching and the mostly-inertCLOEXECdescriptor flag, so I think any possible problems can be mitigated easily.Note we also are not consistent about setting
CLOEXECright now anyway, owing to the JVM's hiding of many descriptors.CLOEXECcleanup and serializing these changes inpopencan come later (if they're needed).