Skip to content

frozen path helper#5884

Merged
enebo merged 1 commit intojruby:masterfrom
ahorek:frozen_path_helper
Sep 23, 2019
Merged

frozen path helper#5884
enebo merged 1 commit intojruby:masterfrom
ahorek:frozen_path_helper

Conversation

@ahorek
Copy link
Contributor

@ahorek ahorek commented Sep 20, 2019

references
https://travis-ci.org/puma/puma/jobs/587423508
puma/puma@c68dfff

FrozenError: can't modify frozen String
  org/jruby/RubyString.java:2684:in `<<'
  uri:classloader:/jruby/path_helper.rb:59:in `block in quote_sensitive_split'
  org/jruby/RubyString.java:5645:in `each_char'
  uri:classloader:/jruby/path_helper.rb:19:in `quote_sensitive_split'
  uri:classloader:/jruby/path_helper.rb:94:in `smart_split_command'
  org/jruby/RubyKernel.java:1780:in `_exec_internal'
  uri:classloader:/jruby/kernel/kernel.rb:4:in `exec'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/lib/bundler/cli/exec.rb:53:in `kernel_exec'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/lib/bundler/cli/exec.rb:34:in `run'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/lib/bundler/cli.rb:465:in `exec'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/lib/bundler/vendor/thor/lib/thor.rb:387:in `dispatch'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/lib/bundler/cli.rb:27:in `dispatch'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/lib/bundler/vendor/thor/lib/thor/base.rb:466:in `start'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/lib/bundler/cli.rb:18:in `start'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/exe/bundle:30:in `block in <main>'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/lib/bundler/friendly_errors.rb:124:in  with_friendly_errors'
  /home/travis/.rvm/gems/jruby-head/gems/bundler-2.0.2/exe/bundle:22:in `<main>'
  org/jruby/RubyKernel.java:1028:in `load'
  /home/travis/.rvm/gems/jruby-head/bin/bundle:23:in `<main>'
  org/jruby/RubyKernel.java:1067:in `eval'
  /home/travis/.rvm/gems/jruby-head/bin/jruby_executable_hooks:24:in `<main>'

@enebo enebo added this to the JRuby 9.2.9.0 milestone Sep 23, 2019
@enebo enebo merged commit 10e365c into jruby:master Sep 23, 2019
@enebo
Copy link
Member

enebo commented Sep 23, 2019

@ahorek I do wonder if puma should be expecting it to be mutable in the first place but it is easy to land this. As it exists today it was a mutable string already so no real semantic change.

@ahorek
Copy link
Contributor Author

ahorek commented Sep 23, 2019

if you enable --enable-frozen-string-literal globally, you expect that all files are frozen-string-literals friendly, but in this case the core of jruby isn't.

@enebo
Copy link
Member

enebo commented Sep 23, 2019

@ahorek hah. wow I misread this yeah we are using the shovel to modify the last element. Ignore my comment :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

JRuby 9.2.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ahorek @enebo