Test passing control between two threads in the ConditionVariable spec#5866
Merged
headius merged 1 commit intojruby:masterfrom Oct 27, 2019
Merged
Test passing control between two threads in the ConditionVariable spec#5866headius merged 1 commit intojruby:masterfrom
headius merged 1 commit intojruby:masterfrom
Conversation
Contributor
Author
|
Also, I should note that I used MRI 2.6 to check that this spec can pass. |
Contributor
Author
|
@headius, I'll rebase this onto master to see if it passes now. |
This tests (J)Ruby's ability to safely switch back and forth between two threads that both have locks on a single mutex, as identified in jruby#5863.
Member
|
Excellent, thank you! Assuming this goes green I'll merge it in. |
Member
|
Two suites failed despite my best efforts, but I'm convinced they're just caching problems with the jnr-constants maven artifact. Merging this in...thank you for your thoroughness @asppsa! |
Member
|
@asppsa Thanks for this good spec, it also caught a bug in TruffleRuby! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tests (J)Ruby's ability to safely switch back and forth between two threads that both have locks on a single mutex, as identified in #5863.
I'm happy to make changes to this spec if needed. In particular, I wasn't sure what a suitable timeout should be (went with 5 seconds), and also whether to add this to the spec for
#signalor#wait. I went with#signalbecause it seems that the failure is in the ability to wake up after going to sleep.