Conversation
Member
Author
|
The first commit removes backtrace and frame push/pop around loads of Ruby code. Ruby code in all execution modes pushes its own frame and backtrace, so this is unnecessary and messes up backtraces. |
The backtrace pushes here are not needed, since the interpreter pushes its own backtrace (in INTERPRET_ROOT) and AOT code uses the Java stacktrace. The frame pushes are moved into the interpreter, since the JIT does not need them.
headius
force-pushed
the
backtrace_fixes
branch
from
4411288 to
20e0c0e
Compare
headius
added a commit
that referenced
this pull request
Aug 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes improvements to how we manage the Ruby backtrace. It will fix #5849 among others.