Fix tracer.rb and get it running in CI#5850
Merged
enebo merged 1 commit intojruby:masterfrom Aug 27, 2019
Merged
Conversation
This relates to jruby#5847 and jruby#5795. The diffs from CRuby in our tracer.rb were not quite equivalent since the original would also accespt a Proc passed as an argument. I've changed the logic here to use that argument or fall back on a passed block. There's also changes to how we invoke event hooks. The first just unifies the JIT and interpreter to call the same logic. The the second mimics CRuby when there's a frame klass and it is either an included module or a singleton. These latter changes fix the remaining failures in CRuby's test_tracer.rb.
Member
Author
|
The remaining failure was fixed in #5851. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #5847.
Note that the tracer tests are almost green, except for #5849 causing one failure in interpreted mode. I have excluded that test for now.