Wrap Process.wait* calls with pthread_kill logic.#5848
Merged
headius merged 1 commit intojruby:masterfrom Aug 29, 2019
Merged
Conversation
This addresses jruby#1050 in the same way CRuby implements this. In CRuby, the wait functions are called directly, and the `pthread_kill` function is used to force the call to be interrupted. It turns out the JVM also uses `pthread_kill` to interrupt blocking native calls, so we use the same binding they do. Note that this will only be used on non-Windows, but the JDK's binding of `NativeThread.signal` might already be stubbed out there.
headius
force-pushed
the
pthread_kill_waits
branch
from
6cc6f27 to
792f5f6
Compare
Member
Author
|
@enebo Any concerns here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #1050 in the same way CRuby implements this. In
CRuby, the wait functions are called directly, and the
pthread_killfunction is used to force the call to beinterrupted. It turns out the JVM also uses
pthread_killtointerrupt blocking native calls, so we use the same binding they
do.
Note that this will only be used on non-Windows, but the JDK's
binding of
NativeThread.signalmight already be stubbed outthere.