Skip to content

[fix] Enumerable#first block signature (matches MRI)#5812

Merged
enebo merged 5 commits intomasterfrom
enum-yield
Aug 5, 2019
Merged

[fix] Enumerable#first block signature (matches MRI)#5812
enebo merged 5 commits intomasterfrom
enum-yield

Conversation

@kares
Copy link
Member

@kares kares commented Aug 2, 2019

we can than remove the hack from #2458

... and get some reported (Enumerator) behaviour to work properly, namely :

kares added 4 commits August 2, 2019 08:03
seems we can than eliminate the Yielder#<< hack
also from comments GH-3814 which are now passing

`Enumerator.new { |y| y.yield([1]) }.lazy.map { |e| e }.to_a`
seems to be left not working as in MRI
@kares
Copy link
Member Author

kares commented Aug 2, 2019

its pretty much just: efd997d#diff-f67f366aa306d84a4fc25d3cd8f340b8R409
... feels like I might be missing smt here, since that resolves the Enumerator backed first issues

... and move the heavy lifting `isFixed()` condition last
@kares kares added this to the JRuby 9.2.8.0 milestone Aug 2, 2019
@kares
Copy link
Member Author

kares commented Aug 2, 2019

targeting 9.2.8.0 since #5044 is targeted for 9.2.8.0 atm

@kares kares requested a review from headius August 5, 2019 06:03
@enebo enebo merged commit 96d8c16 into master Aug 5, 2019
@kares kares deleted the enum-yield branch August 6, 2019 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lazy map adds extra array layer to single-element array output

3 participants