MRI compatibility with IO::sysopen for serial ports on windows#5809
Merged
enebo merged 3 commits intojruby:masterfrom Aug 2, 2019
Merged
MRI compatibility with IO::sysopen for serial ports on windows#5809enebo merged 3 commits intojruby:masterfrom
enebo merged 3 commits intojruby:masterfrom
Conversation
…File::RDWR) works on windows
…handle instead of fake handles. Lazily create to avoid taking too many resources.
headius
reviewed
Aug 1, 2019
headius
requested changes
Aug 1, 2019
Member
headius
left a comment
headius
left a comment
There was a problem hiding this comment.
Seems ok but need to ensure this falls back to old behavior gracefully when native support is disabled (-Xnative.enabled=false or JVM -Djruby.native.enabled=false).
headius
approved these changes
Aug 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes make JRuby be compatible with MRI's API's and behaviors on Windows serial ports.
Fileno is now real in most cases, but lazily generated in most cases to avoid sucking up 2x the number of file resources.
I put the WinC interface in FilenoUtils arbitrarily, I wasn't sure the best place to put it