Do not bind accessors for Java interface-based constant values#5732
Merged
headius merged 1 commit intojruby:masterfrom Mar 4, 2020
Merged
Do not bind accessors for Java interface-based constant values#5732headius merged 1 commit intojruby:masterfrom
headius merged 1 commit intojruby:masterfrom
Conversation
headius
force-pushed
the
remove_constant_accessors
branch
from
4f0fe40 to
49dba9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the unintended behavior that binds an accessor as well as a constant for constant (final) fields on interfaces. It was introduced a long time ago and only recently noticed since Java 9+ prevented the accessor from being created. We are deprecating this in JRuby 9.2.8.0 (#5731) for removal in 9.3.
See #5730.