[ji] to_time conversion for Java DateTime types#5703
Merged
kares merged 2 commits intojruby:masterfrom Apr 30, 2019
Merged
Conversation
headius
approved these changes
Apr 26, 2019
Member
|
@kares This looks fine to me, and I know having stuff in Ruby hurts startup, but I am reluctant to keep adding these extensions in Java. Maybe it's not a huge deal...there's going to be a small number of core JDK types we want to be able to easily roundtrip. |
Member
Author
|
it wont load on startup, we lazy add these as the Java class gets used. so adding more of these wont hurt startup performance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should be good to go, a further extension would be to have a
to_datefor Java date types