[ji] align Java array (with post 1.8 conventions)#5700
Merged
enebo merged 3 commits intojruby:masterfrom Aug 22, 2019
Merged
Conversation
a relict from 1.8 times -> Ruby 2.X uses IndexError on Array
wasn't spec-ed and has been erroring when index started before 0
Member
|
This change seems ok to me even for a shorter-term merge. Someone might rely on it raising an error, but I think it would have to be a pretty weird case. |
Member
Author
|
okay, its fine by me wherever it ends up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
j_ary = [ 1 ].to_java; j_ary[2]shall raiseIndexError(instead ofArgumentError)[ "a", "b", "c" ].to_java[-10..2]similar to a RubyArray(nil)the first one might be considered a bug as well as a breaking change -> maybe target 9.3?