pass -ea to JVM and fix asserts for test targets#5693
Merged
headius merged 5 commits intojruby:masterfrom Apr 12, 2019
Merged
Conversation
headius
added a commit
that referenced
this pull request
Apr 12, 2019
Block aggregates a Binding which aggregates a Frame which aggregates a Block, so having these all initialize statically caused at least one of those reference to end up null. In #5693 this manifested as a failure to dup the frame for a Symbol proc, since Symbol procs are initialized with Frame.DUMMY, which static initialized before Block, so Block.NULL_BLOCK was null and as a result the block field in Frame was null and triggered asserts. Block.NULL_BLOCK, as the most heavily used, remains as the sole static "dummy" in this cycle. NULL_BLOCK is initialized with a new Binding containing an uninitialized Frame, and then the Frame is updated to point back to NULL_BLOCK. This avoids the circulate initialization. Previous references to the dummy Frame and dummy Binding now use NULL_BLOCK's contents. See #5692 for the catch-all issue that goes with PR #5693.
Member
|
I believe I've fixed the null block duping on master, in 3095263. |
it did not work for a while (was noticed at jrubyGH-5612) assertions are enabled in tests since: 21e4663
…a asserts are enabled
... and these will fail for anon classes (starting with a digit)
... setting up (anonymous) Java class wrappers
headius
added a commit
that referenced
this pull request
Apr 12, 2019
Member
|
ManyVarsDynamicScope is fixed on master. |
Member
|
I do not see any other failures on your branch that we haven't addressed, so I'm going to merge. We'll fix anything left on master, but hopefully it's green. |
This was referenced Sep 28, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... also incorporates #5612
there's one assert left that is failing related to frame dup-ing (for procs)